[PATCH 3/3] qemuxml2argvmock: Mock virNumaNodesetIsAvailable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



And yet again one fix of 90286418. The problem is, if libvirt is
built with NUMA disabled (--without-numad --without-numactl), the
testsuite doesn't count on that and some tests fail. This is
because the virNumaNodesetIsAvailable() function is taken from
another section of virnuma.c which contains functions stubs for
case NUMA is disabled at build time. And the function basically
yields an error. However, we want our testsuite to be
deterministic and hence we ought to mock the function.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
 tests/qemuxml2argvmock.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tests/qemuxml2argvmock.c b/tests/qemuxml2argvmock.c
index 7218747..7b8bdd6 100644
--- a/tests/qemuxml2argvmock.c
+++ b/tests/qemuxml2argvmock.c
@@ -39,3 +39,12 @@ virNumaGetMaxNode(void)
 
    return maxnodesNum;
 }
+
+bool
+virNumaNodesetIsAvailable(virDomainNumatunePtr numatune)
+{
+    int maxGuestNode = virDomainNumatuneSpecifiedMaxNode(numatune);
+    int maxHostNode = virNumaGetMaxNode();
+
+    return maxGuestNode <= maxHostNode;
+}
-- 
2.0.4

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]