On 10/31/2014 07:34 PM, John Ferlan wrote: > > > On 10/31/2014 12:01 PM, Ján Tomko wrote: >> Since commit 3f99d64 no new scsi_host pools can be defined >> if one of the already defined scsi_host pools does not refer >> to an accessible scsi_host adapter. >> >> Relax the check by skipping over these inaccessible pools >> when checking for duplicates. If both of them are defined by >> their parent, only compare their address and unique_id with >> the re-introduced matchSCSIAdapterParent function. >> --- >> This would be nice to get into 1.2.10, as the commit mentioned >> above has not yet been released. > > I see no issue with that... > > My only query/thought is whether this should be two patches? > > #1 reintroduce match function > #2 adjust/fix second check > I've split the patch into two. >> >> src/conf/storage_conf.c | 35 ++++++++++++++++++++++++++++++----- >> 1 file changed, 30 insertions(+), 5 deletions(-) >> > > OK - so this makes sense. > > Removal of match parent code was based mostly on the premise we have a > valid scsi_host data being looked at. I guess it seems odd to me someone > would go through the iterations necessary in order to define/create one > that wouldn't be checked to be working first before making their second > attempt. Nonetheless what you have works, so... > > ACK > > John Thanks, pushed now. Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list