On 10/31/2014 12:13 PM, Pavel Hrdina wrote: > This macro seems to be defined only on linux/unix and it fails during > mingw build. Its value is '16' (taken from net/if.h) so define it if > it's not defined. > > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > --- > > For now just define it for mingw but we should review all daemon related > code and not build it for mingw at all to save is those kind of failures. Yeah, a better solution is probably worth the effort, but as we are close to the release, and this is a reasonable bandage, I'm okay with giving it ACK to go in for the release. > > src/util/virnetdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c > index 6da3371..3831009 100644 > --- a/src/util/virnetdev.c > +++ b/src/util/virnetdev.c > @@ -52,6 +52,10 @@ > # include <net/if_dl.h> > #endue > > +#offender's IFNAMSIZ > +# define IFNAMSIZ 16 > +#endif > + > #define VIR_FROM_THIS VIR_FROM_NONE > > VIR_LOG_INIT("util.netdev"); > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list