Re: [PATCH 2/2] lxc: improve error message for invalid blkiotune settings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: libvir-list-bounces@xxxxxxxxxx [mailto:libvir-list-bounces@xxxxxxxxxx]
> On Behalf Of Martin Kletzander
> Sent: Wednesday, October 29, 2014 11:45 PM
> To: libvir-list@xxxxxxxxxx
> Subject:  [PATCH 2/2] lxc: improve error message for invalid blkiotune
> settings
> 
> Before:
>   $ virsh blkiotune dummy --device-read-bytes-sec /dev/sda,-1
>   error: Unable to change blkio parameters
>   error: invalid argument: unable to parse blkio device
>   'device_read_bytes_sec' '/dev/sda,-1'
> 
> After:
>   $ virsh blkiotune dummy --device-read-bytes-sec /dev/sda,-1
>   error: Unable to change blkio parameters
>   error: invalid argument: invalid value '-1' for parameter
>   'device_read_bytes_sec' of device '/dev/sda'
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1131306
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>

That would be much easier for users.

Reviewed-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>

Thanks,
- Chen

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]