> I don't think it's safe to pass arbitrary arguments from XML. I find this > too critical to ACK the patch, buy maybe further discussion can change my > mind. Michal, You're reviewing a 4-revision old version of this patch, see v5 for the most recent set. However, this bit is still present in v5. What is <bootloader_args> in the XML is for, if not arbitrary arguments? Thanks, Conrad -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list