Re: [PATCH] qemu_agent: Produce more readable error messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28.10.2014 16:09, Eric Blake wrote:
On 10/27/2014 08:59 PM, Michal Privoznik wrote:
Not every error message from qemu-ga has to have the 'class' field
filled out. For instance, I've seen this error message lately:

Is that a bug in qemu-ga?  Worth asking on the qemu list.  But we have
to deal with it in the meantime, so this patch is still worthwhile.


This seems to be rather very old qemu-ga. I was unable to reproduce this with the latest one. So it's probably fixed.


   qemuAgentCheckError:1047 : unable to execute QEMU agent command \
   {"execute":"guest-set-time"}: \
   {"error":{"desc":"Invalid parameter type, expected: integer"}}

However, this got translated into rather generic error message:

   internal error: unable to execute QEMU agent command
   'guest-set-time': unknown QEMU command error

So we've dropped better error message in favor of a generic one.
This is due to our code which expects 'class' which is not
present here.


ACK.


And pushed now. Thanks!

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]