On 10/23/2014 09:14 AM, Daniel P. Berrange wrote:
> The phyp_driver.h file has various declarations that are only
> ever used from phyp_driver.c, so they should be in the .c file
> only.
> ---
> src/phyp/phyp_driver.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++
> src/phyp/phyp_driver.h | 53 --------------------------------------------------
> 2 files changed, 49 insertions(+), 53 deletions(-)
ACK.
>
> diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
> index a56f25d..caab499 100644
> --- a/src/phyp/phyp_driver.c
> +++ b/src/phyp/phyp_driver.c
> @@ -41,6 +41,7 @@
> #include <fcntl.h>
> #include <domain_event.h>
> #include <poll.h>
> +#include <libssh2.h>
>
> #include "internal.h"
> #include "virauth.h"
> @@ -63,6 +64,54 @@
>
> VIR_LOG_INIT("phyp.phyp_driver");
>
> +# define LPAR_EXEC_ERR -1
> +# define SSH_CONN_ERR -2 /* error while trying to connect to remote host */
> +# define SSH_CMD_ERR -3 /* error while trying to execute the remote cmd */
Hmm. These are under-parenthesized. Maybe you can touch them up while
moving them?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list