On Sat, Oct 25, 2014 at 6:30 AM, Eric Blake <eblake@xxxxxxxxxx> wrote: > On 10/07/2014 05:14 AM, Matthias Gatto wrote: >> Detect if the the qemu binary currently in use suport the bps_max option, >> If yes add it to the command, if not, just ignore the options. > > Ignoring options is wrong. If a user explicitly requested something in > XML but the hypervisor cannot honor it, we want to error out. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > But I've already check this in qemu_driver.c We can check it twice, but will it be really useful ? Maybe I should write the check has already been made in the commit message ? -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list