On 10/07/2014 05:14 AM, Matthias Gatto wrote:
> Modify the structure _virDomainBlockIoTuneInfo to support these the new
> options.
> Change the initialization of the variable expectedInfo in qemumonitorjsontest.c
> to avoid compiling problem.
> Add documentation about the new xml options
>
> Signed-off-by: Matthias Gatto <matthias.gatto@xxxxxxxxxxxx>
> ---
> docs/formatdomain.html.in | 25 ++++++++++
> docs/schemas/domaincommon.rng | 43 +++++++++++++++++
> src/conf/domain_conf.c | 110 +++++++++++++++++++++++++++++++++++++++++-
> src/conf/domain_conf.h | 7 +++
> tests/qemumonitorjsontest.c | 2 +-
> 5 files changed, 185 insertions(+), 2 deletions(-)
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 45b0f61..6ec7b6b 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -2103,6 +2103,31 @@
> <dt><code>write_iops_sec</code></dt>
> <dd>The optional <code>write_iops_sec</code> element is the
> write I/O operations per second.</dd>
> + <dt><code>total_bytes_sec_max</code></dt>
> + <dd>The optional <code>total_bytes_sec_max</code> element is the
> + maximum total throughput limit in bytes per second. This cannot
> + appear with <code>read_bytes_sec_max</code>
> + or <code>write_bytes_sec_max</code>.</dd>
Would be worth a 'since 1.2.9' designation throughout this section.
> +
> + if (def->blkdeviotune.read_bytes_sec_max) {
> + virBufferAsprintf(buf, "<read_bytes_sec_max>%llu</read_bytes_sec_max>\n",
> + def->blkdeviotune.read_bytes_sec_max);
> +
> + }
Awkward blank line before the }.
ACK; I can fix up the docs and the blank line.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list