Re: [PATCH 02/12] Move virNetwork related APIs out of libvirt.h.in

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/23/2014 06:58 AM, Daniel P. Berrange wrote:
> Create a new libvirt-network.h file to hold the public
> API definitions for the virNetwork type. This header
> file is not self-contained, so applications will not directly
> include it. They will contain to #include <libvirt/libvirt.h>

s/contain/continue/ (looks like a pervasive copy-and-paste throughout
your series)

> ---
>  include/libvirt/libvirt-network.h | 337 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 337 insertions(+)
>  create mode 100644 include/libvirt/libvirt-network.h

Umm, this diffstat is wrong.  Looks like you split things incorrectly,
and that patch 3/12 contains the remaining half of this patch (the part
that adds a Makefile.am entry and removes the corresponding lines from
libvirt.h.in).  Bisection is not broken with this patch as-is, because
the file is not used, but I'd rather you fix it properly before pushing :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]