Re: [PATCH 09/12] Move virStream related APIs out of libvirt.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/22/2014 11:14 AM, Daniel P. Berrange wrote:
> Introduce a src/libvirt-stream.c file to hold all the
> methods related to the virStream type.
> ---
>  cfg.mk               |   4 +-
>  docs/apibuild.py     |   1 +
>  po/POTFILES.in       |   1 +
>  src/Makefile.am      |   2 +
>  src/libvirt-stream.c | 704 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  src/libvirt.c        | 675 ------------------------------------------------
>  6 files changed, 710 insertions(+), 677 deletions(-)
>  create mode 100644 src/libvirt-stream.c

ACK.  Slightly more changes than some of the others outside of the code
motion, but that's okay.

> +++ b/cfg.mk
> @@ -1040,7 +1040,7 @@ $(srcdir)/src/remote/remote_client_bodies.h: $(srcdir)/src/remote/remote_protoco
>  # List all syntax-check exemptions:
>  exclude_file_name_regexp--sc_avoid_strcase = ^tools/virsh\.h$$
>  
> -_src1=libvirt|fdstream|qemu/qemu_monitor|util/(vircommand|virfile)|xen/xend_internal|rpc/virnetsocket|lxc/lxc_controller|locking/lock_daemon
> +_src1=libvirt-stream|fdstream|qemu/qemu_monitor|util/(vircommand|virfile)|xen/xend_internal|rpc/virnetsocket|lxc/lxc_controller|locking/lock_daemon
>  _test1=shunloadtest|virnettlscontexttest|virnettlssessiontest|vircgroupmock
>  exclude_file_name_regexp--sc_avoid_write = \
>    ^(src/($(_src1))|daemon/libvirtd|tools/virsh-console|tests/($(_test1)))\.c$$
> @@ -1070,7 +1070,7 @@ exclude_file_name_regexp--sc_prohibit_strdup = \
>    ^(docs/|examples/|src/util/virstring\.c|tests/virnetserverclientmock.c$$)
>  
>  exclude_file_name_regexp--sc_prohibit_close = \
> -  (\.p[yl]$$|^docs/|^(src/util/virfile\.c|src/libvirt\.c|tests/vir(cgroup|pci)mock\.c)$$)
> +  (\.p[yl]$$|^docs/|^(src/util/virfile\.c|src/libvirt-stream\.c|tests/vir(cgroup|pci)mock\.c)$$)

Nice that our syntax check exclusions are now tied to smaller .c files :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]