Re: [PATCH 0/3] Fix handling of data returned by XML hooks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 22, 2014 at 11:48:03AM +0200, Peter Krempa wrote:
Peter Krempa (3):
 util: string: Add helper to check whether string is empty
 qemu: restore: Fix restoring of VM when the restore hook returns empty
   XML
 qemu: migration: Make check for empty hook XML robust

src/libvirt_private.syms  |  1 +
src/qemu/qemu_driver.c    |  2 +-
src/qemu/qemu_migration.c |  2 +-
src/util/virstring.c      | 16 ++++++++++++++++
src/util/virstring.h      |  2 ++
5 files changed, 21 insertions(+), 2 deletions(-)

--
2.1.0


You're still missing one check in qemuDomainObjRestore(), but it's the
last one.  Fixing this in virHookCall() seems to make it unnecessarily
complicated.  ACK if you fix qemuDomainObjRestore() as well.

Martin

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]