On Wed, Oct 22, 2014 at 01:31:41PM +0400, Dmitry Guryanov wrote: > On Tuesday 14 October 2014 18:23:31 you wrote: > > This patch series replaces a series of functions, which > > retieve different domains info and modifies domains state > > with new ones, which use parallels sdk instead of executing > > prlctl command. > > > > These functions don't use cached domains list > > _parallelsConn.domains, so when we rewrite all code, we > > will be able to remove it. > > > > Hello, > > We have decided to keep the list of domains parallelsConn.domains. > To keep it up-to-date we subscribe to events from PCS and modify > it when events about new, removed or changed domains occur. > > It's better because first, the file parallels_driver.c will be similar > to corresponding files in other drivers, so it'll be easier to maintain > it, second, it will be faster, because requesting domain info from PCS > takes some time, and also it needs less modifications of current code. > > So, please, don't review these patches, I've already implemented this > new approach and will send it today or tomorrow. That sounds good - listening to events from PCS is also beneficial because it will let you support the libvirt domain lifecycle event API, so that mgmt apps using libvirt can get notifications of VMs changing state. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list