Re: [python PATCH] Fix flags cannot get right value for blockCopy function

[Pavel Hrdina <phrdina@xxxxxxxxxx>]

On 10/22/2014 07:18 AM, Luyao Huang wrote:
> When use blockCopy, flags cannot get a right value, because
> PyArg_ParseTuple want to get 6 parameters and blockCopy only
> pass 5.Flags will get a unpredictable value, this will make
> this function cannot be used.And error just like:
>
> unsupported flags (0x7f6c) in function qemuDomainBlockCopy
>
> Signed-off-by: Luyao Huang <lhuang@xxxxxxxxxx>
> ---
>   libvirt-override.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libvirt-override.c b/libvirt-override.c
> index c887b71..4999ac3 100644
> --- a/libvirt-override.c
> +++ b/libvirt-override.c
> @@ -8175,8 +8175,7 @@ libvirt_virDomainBlockCopy(PyObject *self ATTRIBUTE_UNUSED, PyObject *args)
>       int c_retval;
>
>       if (!PyArg_ParseTuple(args, (char *) "Ozz|Oi:virDomainBlockCopy",
> -                          &pyobj_dom, &disk, &destxml, &pyobj_dict, &params,
> -                          &flags))
> +                          &pyobj_dom, &disk, &destxml, &pyobj_dict, &flags))
>           return VIR_PY_INT_FAIL;
>
>       if (PyDict_Check(pyobj_dict)) {

ACK

I've slightly updated the commit message and pushed it.

Pavel

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list