Re: [PATCH] conf: tests: fix virDomainNetDefFormat for vhost-user in client mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/17/14 18:45, Maxime Leroy wrote:
> The mode attribute is required for the source element of vhost-user. Thus
> virDomainNetDefFormat should always generate a xml with it, and
> not only when the mode is server.
> 
> The commit fixes the issue. And it adds a vhostuser interface in 'client' mode
> to qemuxml2argv-net-vhostuser.(args|xml) to test this usecase.
> 
> Signed-off-by: Maxime Leroy <maxime.leroy@xxxxxxxxx>

I've reflowed your commit message to break a few long lines.


> ---
>  src/conf/domain_conf.c                                 | 5 +++--
>  tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser.args | 7 +++++--
>  tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser.xml  | 7 ++++++-
>  3 files changed, 14 insertions(+), 5 deletions(-)
> 

and pushed your patch. Thanks for taking time to provide a test case.

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]