Re: [PATCH] qemu: command: Allow UEFI for non-x86

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14.10.2014 09:42, Cole Robinson wrote:
It's supported on aarch64 and armv7l as well, so just drop the restriction
entirely since it doesn't add much.
---
  src/qemu/qemu_command.c | 8 --------
  1 file changed, 8 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 8cb0865..2872e47 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -7672,14 +7672,6 @@ qemuBuildDomainLoaderCommandLine(virCommandPtr cmd,
          break;

      case VIR_DOMAIN_LOADER_TYPE_PFLASH:
-        /* UEFI is supported only for x86_64 currently */
-        if (def->os.arch != VIR_ARCH_X86_64) {

I think it would be better to deliberately allow arches we want. As far as I understand the cmd line generated to use UEFI can vary depending on the guest architecture, is that right Laszlo? If it is so, ACK to the opposite patch :)

-            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                           _("pflash is not supported for %s guest architecture"),
-                           virArchToString(def->os.arch));
-            goto cleanup;
-        }
-
          if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DRIVE)) {
              virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                             _("this QEMU binary doesn't support -drive"));


Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]