Re: [PATCH 01/21] Added missing virBufferFreeAndReset on the query buffer to free some memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/10/2014 07:00 AM, Eric Blake wrote:

>> 	Right; there are potential paths through which the query buffer may be not released (in hypervEnumAndPull).
> 
> Not if you take my alternate proposed 1/21 patch.
> 
>> 	For safety, I systematically added this line for any local virBuffer variable.
> 
> I'd rather fix the one function than have to fix every caller.
> 

Hmm, did you even see my alternative proposal? I may have forgotten to
cc you:

https://www.redhat.com/archives/libvir-list/2014-October/msg00284.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]