Re: [PATCHv2 0/3] Save domain satus after change some parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/06/2014 05:00 PM, Shanzhi Yu wrote:
Related bug: https://bugzilla.redhat.com/show_bug.cgi?id=1146511

Also add BeginJob/EndJob in qemuDomainSetBlkioParameters,
qemuDomainSetInterfaceParameters,qemuDomainSetNumaParameters


Shanzhi Yu (3):
   qemu: save domain status after set the blkio parameters
   qemu: call qemuDomainObjBeginJob/qemuDomainObjEndJob in
     qemuDomainSetInterfaceParameters
   qemu: save domain status after set domain's numa parameters

  src/qemu/qemu_driver.c | 76 ++++++++++++++++++++++++++++++++++----------------
  1 file changed, 52 insertions(+), 24 deletions(-)


The patches looks OK. I have only just one thing to mention that for
the "qemuDomainSetBlkioParameters" the values are not stored in the
internal VM definition, they are directly applied into the cgroups and
getting the values is done by asking the cgroups.

The values then survived the restart of libvirtd, but it should definitely be stored in the internal VM definition. But this is
a different issue and should be addressed by its own patch series.

ACK and pushed,

Thanks, Pavel.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]