Re: [PATCH] Introduce virStringStripIPv6Brackets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/08/2014 11:10 AM, Daniel P. Berrange wrote:
> On Wed, Oct 08, 2014 at 10:46:53AM +0200, Ján Tomko wrote:
>> Helper function to strip the brackets from an IPv6 address.
>> Tested by viruritest.
>> ---
>>  src/libvirt_private.syms |  1 +
>>  src/util/virstring.c     | 22 ++++++++++++++++++++++
>>  src/util/virstring.h     |  2 ++
>>  src/util/viruri.c        | 20 ++++----------------
>>  4 files changed, 29 insertions(+), 16 deletions(-)
> 
> Can we have tests in viruritest.c and virstringtest.c too
> 

We already test it on sane inputs in viruritest.

I've added some corner cases to virstringtest in v2.

> 
> Regards,
> Daniel
> 

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]