On 09/24/2014 09:27 AM, John Ferlan wrote:
> Check for !dev->info.alias was done after a VIR_DEBUG() statement
> that already tried to print - just flip sequence
>
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
ACK to this re-arranged version
> src/qemu/qemu_hotplug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
> index 8011a83..d158a73 100644
> --- a/src/qemu/qemu_hotplug.c
> +++ b/src/qemu/qemu_hotplug.c
> @@ -1887,14 +1887,14 @@ int qemuDomainChangeNetLinkState(virQEMUDriverPtr driver,
> int ret = -1;
> qemuDomainObjPrivatePtr priv = vm->privateData;
>
> - VIR_DEBUG("dev: %s, state: %d", dev->info.alias, linkstate);
> -
> if (!dev->info.alias) {
> virReportError(VIR_ERR_OPERATION_FAILED, "%s",
> _("can't change link state: device alias not found"));
> return -1;
> }
>
> + VIR_DEBUG("dev: %s, state: %d", dev->info.alias, linkstate);
> +
> qemuDomainObjEnterMonitor(driver, vm);
>
> ret = qemuMonitorSetLink(priv->mon, dev->info.alias, linkstate);
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list