On 09/27/2014 12:40 AM, Amos Kong wrote: > On Wed, Sep 24, 2014 at 05:50:53AM -0400, Laine Stump wrote: >> This same structure will be used to retrieve RX filter info for >> interfaces on the host via netlink messages, and RX filter info for >> interfaces on the guest via the qemu "query-rx-filter" command. >> --- >> src/libvirt_private.syms | 8 +++++++ >> src/util/virnetdev.c | 40 +++++++++++++++++++++++++++++++++ >> src/util/virnetdev.h | 57 +++++++++++++++++++++++++++++++++++++++++++++++- >> 3 files changed, 104 insertions(+), 1 deletion(-) >> >> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms >> index bb2b9a3..e5723d2 100644 >> --- a/src/libvirt_private.syms >> +++ b/src/libvirt_private.syms >> @@ -1595,6 +1595,14 @@ virNetDevReplaceMacAddress; >> virNetDevReplaceNetConfig; >> virNetDevRestoreMacAddress; >> virNetDevRestoreNetConfig; >> +virNetDevRxFilterFree; >> +virNetDevRxFilterMulticastModeTypeFromString; >> +virNetDevRxFilterMulticastModeTypeToString; >> +virNetDevRxFilterNew; >> +virNetDevRxFilterUnicastModeTypeFromString; >> +virNetDevRxFilterUnicastModeTypeToString; >> +virNetDevRxFilterVlanModeTypeFromString; >> +virNetDevRxFilterVlanModeTypeToString; > The RxFilter ModeTypes of unicast, multicast, vlan are same > > 'normal', 'none', 'all' > > Can we just use some general functions to process the string? > > virNetDevRxFilterModeTypeFromString; > virNetDevRxFilterModeTypeToString; Yep, I've already made that change for V2. I had madde separe enums in the beginning because it wasn't yet clear to me that they would have identical possible values. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list