Re: [libvirt] [PATCH] fix just-broken "virsh start" and "virsh pool-start" commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jim Meyering wrote:
> * src/virsh.c (cmdPoolStart, cmdStart): Change hard-coded
> vshCommandOptDomainBy string argument to match just-changed
> option name.  Cole Robinson reported that "virsh start" was
> broken and provided that part of the fix.
> Bug introduced by yesterday's "virsh.c: tweak options to produce
> more accurate help".
> * tests/start: New file.  Test for the above fix.
> * tests/Makefile.am (test_scripts): Add start.
> ---
> 
> Without this change, "virsh start" and "virsh pool-start"
> would always fail.
> 
> I'm fixing this in two steps: first is this patch: make the tiny
> string-changing fixes (along with the new test).
> Second will be a more invasive change to make it so the duplicate
> strings are removed altogether, so they'll never get out of sync again.
> 
> 

ACK.

- Cole

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]