On 09/24/2014 01:24 AM, John Ferlan wrote: > > > On 09/18/2014 10:15 AM, Ján Tomko wrote: >> Format the segment offloading options specified by >> <driver> >> <host .../> >> <guest .../> >> </driver> >> on virtio-net command line. >> --- >> src/qemu/qemu_command.c | 40 ++++++++++++++++++++++ >> .../qemuxml2argv-net-virtio-disable-offloads.args | 10 ++++++ >> tests/qemuxml2argvtest.c | 2 ++ >> 3 files changed, 52 insertions(+) >> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-net-virtio-disable-offloads.args >> >> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-virtio-disable-offloads.args b/tests/qemuxml2argvdata/qemuxml2argv-net-virtio-disable-offloads.args >> new file mode 100644 >> index 0000000..3328988 >> --- /dev/null >> +++ b/tests/qemuxml2argvdata/qemuxml2argv-net-virtio-disable-offloads.args >> @@ -0,0 +1,10 @@ >> +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \ >> +/usr/bin/qemu -S -M pc -m 214 -smp 1 -nographic -nodefconfig -nodefaults \ >> +-monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -usb \ >> +-hda /dev/HostVG/QEMUGuest7 \ >> +-device virtio-net-pci,csum=off,gso=off,\ >> +host_tso4=off,host_tso6=off,host_ecn=off,host_ufo=off,\ >> +guest_tso4=off,guest_tso6=off,guest_ecn=off,guest_ufo=off,\ > > This may need a "guest_csum=off," Oops. I've fixed that, some nits in 1/2 (except the TCP options rename), added <optional> to all the attributes and pushed the series. Jan > > ACK with that > > John
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list