On 09/18/2014 12:01 PM, Pavel Hrdina wrote: > We are not detecting the presence of FIPS from QEMU, but from procfs and > that means it's not QEMU capability. It was decided that we will pass > this flag to QEMU even if it's not supported by old QEMU binaries. > > This patch also reverts changes done by commit a21cfb0f to > qemucapabilitestest and implements a new test case in qemuxml2argvtest. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1135431 > > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > --- > @@ -183,19 +176,16 @@ mymain(void) > > data.xmlopt = xmlopt; > > -#define DO_TEST_FULL(name, use_fips) \ > - data.base = name; \ > - data.fips = use_fips; \ > - if (virtTestRun(name, testQemuCaps, &data) < 0) \ > +#define DO_TEST(name) \ > + data.base = name; \ > + if (virtTestRun(name, testQemuCaps, &data) < 0) \ We are not very consistent on whether multiline macros should align the \ to the same column. > ret = -1 Eww - we really did that in a multiline macro? I'd much rather fix things to use: do { data.base = name; if (virtTestRun(name, testQemuCaps, &data) < 0) ret = -1; } while (0) as long as we are touching the code. ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list