On 09/17/2014 08:57 AM, Daniel P. Berrange wrote:
>>> + <b><driver csum='off' gso='off' guest_tso4='off' guest_tso6='off' guest_ecn='off'/></b>
>>> + </interface>
>>
>> Are we stuck with names with underscores in our XML? I'm still not sure
>> if we've come up with the best naming for exposing all these knobs.
>
> I'm not really convinced having a 'guest_' prefix really buys
> us anything here, since there's no naming clash to avoid. Why
> don't we just kill the 'guest_' prefixes.
>
> NB, remember that precisely matching QEMU naming is a non-goal,
> we should be designing something that makes sense in general.
I agree; I'd be fine with:
<driver csum='off' gso='off' tso4='off' tso6='off' ecn='off'/>
with no need for a <guest> sub-structure. Yeah, we'll have to do some
glue logic to translate to qemu names, but that's what libvirt is for.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list