On 09/11/2014 06:05 PM, John Ferlan wrote: > There are two repeats from the last series (1 & 2). > > For patch 1, I went with my suggestion - I'm open to others > For patch 2, Coverity was complaining more about the way nparams > would be overwritten - fix that by adding a new variable > > New patches > 3 & 4 -> eblake helped out with these - especially the mgetgroups oddity > 5 -> Fallout from fixing 4 > 6 -> virTimeFieldsThen() and the "offset = 0". I'd be OK with deleting the > code, but it just feels like someone had it on a todo list to come > back to some day > 7 & 8 -> Fairly straightforward > 9 -> This was an interesting case - it seems from what was being done > that I have the right "answer". I did go all the way back to the > initial submission of the code and it did the same thing, except it > was using an unsigned long instead of int and well thus wouldn't > ever hit the condition since we're grabbing the big endian int value Too late for me to give a competent review on 1 or 6, I may try again in the morning when I'm not as tired. 3 and 4 are indeed tricky, but I already helped you on it earlier in the day. I've got a question on 9, but again, sleep may help me reason about it better. And with that, I'm off to some much-needed sleep :) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list