On Thu, Sep 04, 2014 at 10:27:12PM -0400, Hongbin Lu wrote: > Thanks Guido, > > Your comment is addressed: > https://www.redhat.com/archives/libvir-list/2014-September/msg00284.html. Great. The migration code looks good to me from a OpenVZ view but I don't feel qualified enough to ACK this from a libvirt point of view since I've lost a bit track over the different migration protocols. Cheers, -- Guido > > Best regards, > Hongbin > > > On Thu, Sep 4, 2014 at 1:42 AM, Guido Günther <agx@xxxxxxxxxxx> wrote: > > > Hi, > > On Wed, Sep 03, 2014 at 11:07:20PM -0400, Hongbin Lu wrote: > > [..snip..] > > > + > > > + if (virAsprintf(uri_out, "tcp://%s", hostname) < 0) > > > + goto error; > > > > Since OpenVZ tunnels over ssh shouldn't this be something like ssh:// > > ? > > > > Cheers, > > -- Guido > > > > > -- > libvir-list mailing list > libvir-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list