Re: [PATCH 12/26] virsh: Resolve Coverity DEADCODE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/05/14 00:26, John Ferlan wrote:
> Coverity points out that if 'dom' isn't returned from virDomainQemuAttach,
> then the code already jumps to cleanup, so there was no need for the
> subsequent if (dom != NULL) check.
> 
> I moved the error message about failure into the goto cleanup on failure
> and then removed the if (dom != NULL)
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  tools/virsh-domain.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 

ACK


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]