Re: [PATCH 17/26] virstring: Resolve Coverity FORWARD_NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/05/14 00:26, John Ferlan wrote:
> Perhaps a false positive, but since Coverity doesn't understand the
> relationship between the 'count' and the 'strings', rather than leave
> the chance the on input 'strings' is NULL and causes a deref - just
> check for it and return
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/util/virstring.c | 3 +++
>  1 file changed, 3 insertions(+)
> 

Yep, false positive. All callers shall pass 0 as count if strings is NULL.

ACK, doesn't hurt.

Peter

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]