On 2014/9/5 6:26, John Ferlan wrote: > If the virJSONValueNewObject() fails, then rather than going to error > and getting a Coverity false positive since it doesn't seem to understand > the relationship between nkeywords, keywords, and values and seems to > believe calling qemuFreeKeywords will cause a NULL deref - just return NULL > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > src/qemu/qemu_monitor_json.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c > index 62e7d5d..b0bc5fc 100644 > --- a/src/qemu/qemu_monitor_json.c > +++ b/src/qemu/qemu_monitor_json.c > @@ -617,7 +617,7 @@ qemuMonitorJSONKeywordStringToJSON(const char *str, const char *firstkeyword) > size_t i; > > if (!(ret = virJSONValueNewObject())) > - goto error; > + return NULL; Maybe it's not enough. > if (qemuParseKeywords(str, &keywords, &values, &nkeywords, 1) < 0) > goto error; Here, qemuParseKeywords() may fail and 'values' is still NULL. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list