Re: [PATCH 4/6] maint: use consistent if-else braces in lxc, vbox, phyp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/03/14 23:25, Eric Blake wrote:
> I'm about to add a syntax check that enforces our documented
> HACKING style of always using matching {} on if-else statements.
> 
> This patch focuses on drivers that had several issues.
> 
> * src/lxc/lxc_fuse.c (lxcProcGetattr, lxcProcReadMeminfo): Correct
> use of {}.
> * src/lxc/lxc_driver.c (lxcDomainMergeBlkioDevice): Likewise.
> * src/phyp/phyp_driver.c (phypConnectNumOfDomainsGeneric)
> (phypUUIDTable_Init, openSSHSession, phypStoragePoolListVolumes)
> (phypConnectListStoragePools, phypDomainSetVcpusFlags)
> (phypStorageVolGetXMLDesc, phypStoragePoolGetXMLDesc)
> (phypConnectListDefinedDomains): Likewise.
> * src/vbox/vbox_common.c (vboxAttachSound, vboxDumpDisplay)
> (vboxDomainRevertToSnapshot, vboxDomainSnapshotDelete): Likewise.
> * src/vbox/vbox_tmpl.c (vboxStorageVolGetXMLDesc): Likewise.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/lxc/lxc_driver.c   | 24 ++++++++++++------------
>  src/lxc/lxc_fuse.c     | 34 ++++++++++++++++++----------------
>  src/phyp/phyp_driver.c | 45 ++++++++++++++++++++++++++-------------------
>  src/vbox/vbox_common.c | 12 ++++++------
>  src/vbox/vbox_tmpl.c   |  3 ++-
>  5 files changed, 64 insertions(+), 54 deletions(-)
> 

ACK,

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]