On 09/03/14 23:25, Eric Blake wrote:
> I'm about to add a syntax check that enforces our documented
> HACKING style of always using matching {} on if-else statements.
>
> This commit focuses on the qemu driver.
>
> * src/qemu/qemu_command.c (qemuParseISCSIString)
> (qemuParseCommandLineDisk, qemuParseCommandLine)
> (qemuBuildSmpArgStr, qemuBuildCommandLine)
> (qemuParseCommandLineDisk, qemuParseCommandLineSmp): Correct use
> of {}.
> * src/qemu/qemu_capabilities.c (virQEMUCapsProbeCPUModels):
> Likewise.
> * src/qemu/qemu_driver.c (qemuDomainCoreDumpWithFormat)
> (qemuDomainRestoreFlags, qemuDomainGetInfo)
> (qemuDomainMergeBlkioDevice): Likewise.
> * src/qemu/qemu_hotplug.c (qemuDomainAttachNetDevice): Likewise.
> * src/qemu/qemu_monitor_text.c (qemuMonitorTextCreateSnapshot)
> (qemuMonitorTextLoadSnapshot, qemuMonitorTextDeleteSnapshot):
> Likewise.
> * src/qemu/qemu_process.c (qemuProcessStop): Likewise.
>
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
> src/qemu/qemu_capabilities.c | 6 ++---
> src/qemu/qemu_command.c | 56 ++++++++++++++++++++++++--------------------
> src/qemu/qemu_driver.c | 36 ++++++++++++++--------------
> src/qemu/qemu_hotplug.c | 9 +++----
> src/qemu/qemu_monitor_text.c | 30 ++++++++----------------
> src/qemu/qemu_process.c | 3 +--
> 6 files changed, 67 insertions(+), 73 deletions(-)
>
ACK
Peter
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list