Re: [python PATCH v2 2/5] API: Skip 'virDomainStatsRecordListFree'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/01/14 22:18, Pavel Hrdina wrote:
> From: Peter Krempa <pkrempa@xxxxxxxxxx>
> 
> The new API function doesn't make sense to be exported in python. The
> bindings will return native types instead of the struct array.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
>  generator.py  | 1 +
>  sanitytest.py | 3 +++
>  2 files changed, 4 insertions(+)
> 

> diff --git a/sanitytest.py b/sanitytest.py
> index 4f4a648..10cf9f0 100644
> --- a/sanitytest.py
> +++ b/sanitytest.py
> @@ -81,6 +81,9 @@ for cname in wantfunctions:
>      if name[0:23] == "virNetworkDHCPLeaseFree":
>          continue
>  
> +    if name[0:28] == "virDomainStatsRecordListFree":
> +        continue
> +

Thanks for catching this. I didn't run the sanity test :/

>      # These aren't functions, they're callback signatures
>      if name in ["virConnectAuthCallbackPtr", "virConnectCloseFunc",
>                  "virStreamSinkFunc", "virStreamSourceFunc", "virStreamEventCallback",
> 

ACK,

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]