On 08/28/2014 06:38 PM, Eric Blake wrote: > On 08/28/2014 10:32 AM, Peter Krempa wrote: >> Setting OCDs aside, sorting enums breaks if the definition contains >> links to other enums defined in the libvirt header before. Let the >> generator generate it in the natural order. >> --- >> generator.py | 2 -- >> 1 file changed, 2 deletions(-) > > ACK. But I _also_ think we need to fix libvirt to recursively resolve > enums defined by reference to other names, so that the API xml file it > generates is fully numeric rather than making clients chase down > symbolic resolutions themselves. > This doesn't fix the issue as it's generated in random order now and sometimes it generate the enums' definition in wrong order so it cannot be resolved. I agree that we should remove that references. NACK Pavel -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list