<...snip...> >> >> Hmmm.. right >> >> Maybe a: >> >> if (event) { >> libxlDomainEventQueue(driver, event); >> event = NULL; >> } >> >> before the: >> >> dom = virGetDomain(dconn, vm->def->name, vm->def->uuid); >> > > Hrm, I wonder if it is even possible for dom to be NULL in this case? > We are in the finish phase and have even unpaused the domain, if > requested. I see that dom == NULL is never checked in > qemuMigrationFinish(). Perhaps the whole 'if (dom == NULL)' check can > be removed here too. > > Regards, > Jim > OK - prior to reading this I just included this as patch 1 of the other Coverity pile I just dumped on the list. If you have an epiphany after reading the code again - let me know - I can adjust it... John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list