On 08/22/2014 04:05 PM, Erik Skultety wrote: > When trying to set numatune mode directly using virsh numatune command, > correct error is raised, however numatune structure was not deallocated, > thus resulting in creating an empty numatune element in the guest XML, > if none was present before. Running the same command aftewards results > in a successful change with broken XML structure. Patch fixes the > deallocation problem as well as checking for invalid attribute > combination VIR_DOMAIN_NUMATUNE_PLACEMENT_AUTO + a nonempty nodeset. > > Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1129998 > --- > src/conf/numatune_conf.c | 45 ++++++++++++++-------- > ...-numad-auto-vcpu-static-numatune-no-nodeset.xml | 31 +++++++++++++++ > tests/qemuxml2argvtest.c | 1 + > 3 files changed, 62 insertions(+), 15 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-numad-auto-vcpu-static-numatune-no-nodeset.xml ACK and pushed Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list