Re: [libvirt] PATCH: 11/28: Reduce return points for UML driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jim Meyering <jim@xxxxxxxxxxxx> wrote:
> Ron Yorston <rmy@xxxxxxxxxxxxx> wrote:
>> "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:
>>> static int umlDomainShutdown(virDomainPtr dom) {
> ...
>>>+    char *info;
> ...
>>>     VIR_FREE(info);
> ...
>> info should be initialised to NULL, otherwise the VIR_FREE will fail.
>> With the umlMonitorCommand if'ed out this is also broken before the
>> patch, which is how I came to notice it.
>>
>> Ron
>
> Thanks for reporting that!
> I'll commit the following shortly:
>
> Mon Nov 30 10:28:21 CET 2008 Jim Meyering <meyering@xxxxxxxxxx>
>
>        uml: don't free an uninitialized variable
>        * src/uml_driver.c (umlDomainShutdown): Initialize "info".
>        Patch and bug report from Ron Yorston <rmy@xxxxxxxxxxxxx>.

Committed.

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]