Re: [PATCH v2 libvirt 2/8] conf, virDomainFSDefPtr: rename "path" argument to "target"

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

On 11.08.2014 16:47, Giuseppe Scrivano wrote:
> Since the target for MTP is a name and not a path, make the function
> more generic.
>
> Signed-off-by: Giuseppe Scrivano <gscrivan@xxxxxxxxxx>
> ---
>   src/conf/domain_conf.c | 4 ++--
>   src/conf/domain_conf.h | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 9252ffa..20de23a 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -18925,12 +18925,12 @@ virDomainFSRemove(virDomainDefPtr def, size_t i)
>
>   virDomainFSDefPtr
>   virDomainGetFilesystemForTarget(virDomainDefPtr def,
> -                                const char *path)
> +                                const char *target)
>   {
>       size_t i;
>
>       for (i = 0; i < def->nfss; i++) {
> -        if (STREQ(def->fss[i]->dst, path))
> +        if (STREQ(def->fss[i]->dst, target))
>               return def->fss[i];
>       }
>
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index d7664e4..748dea7 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -2495,7 +2495,7 @@ int virDiskNameToBusDeviceIndex(virDomainDiskDefPtr disk,
>                                   int *devIdx);
>
>   virDomainFSDefPtr virDomainGetFilesystemForTarget(virDomainDefPtr def,
> -                                                  const char *path);
> +                                                  const char *target);
>   int virDomainFSInsert(virDomainDefPtr def, virDomainFSDefPtr fs);
>   int virDomainFSIndexByName(virDomainDefPtr def, const char *name);
>   virDomainFSDefPtr virDomainFSRemove(virDomainDefPtr def, size_t i);

ACK and can be pushed now.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list