On 08/15/2014 09:50 PM, Jim Fehlig wrote: > XM and XL config are very similar. Disks are specified differently > in XL, but the old XM disk config is still supported by XL. XL also > supports new config like spice that was never supported by XM. > > This patch moves all the common parsing and formatting functions to > the new file xen_common.c and adapts the XM parser/formatter accordingly. > This restructuring paves way for introducing an XL parser/formatter in > the future. > > While moving the code, fixup whitespace, comments, and style issues. > > Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx> > --- > po/POTFILES.in | 1 + > src/Makefile.am | 1 + > src/xenconfig/xen_common.c | 2072 +++++++++++++++++++++++++++++++++++++++++ > src/xenconfig/xen_common.h | 46 + > src/xenconfig/xen_xm.c | 2187 ++------------------------------------------ > src/xenconfig/xen_xm.h | 10 - > 6 files changed, 2205 insertions(+), 2112 deletions(-) Big, but seems mostly mechanical. I checked the diff via: $ diff -u <(sed -n 's/^-//p' patch) <(sed -n 's/^\+//p' patch) to make sure that most of the differences were indeed whitespace. It might have been a better idea to split into a couple of patches (cleaning up style separately from renaming), but not worth the effort to go back and redo it now. ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list