On Thu, Aug 14, 2014 at 02:17:15PM +0200, Martin Kletzander wrote: > On Thu, Aug 14, 2014 at 02:12:51PM +0200, Martin Kletzander wrote: > >On Thu, Aug 14, 2014 at 12:12:33PM +0100, Daniel P. Berrange wrote: > >>On Thu, Aug 14, 2014 at 01:09:32PM +0200, Erik Skultety wrote: > >>>When editing guest's XML (on QEMU), it was possible to add multiple > >>>listen elements into graphics parent element. However QEMU does not > >>>support listening on multiple addresses. This patch causes qemu > >>>post-parse callback to remove any redundant entries, leaving only 1 > >>>listening address if provided, otherwise the configuration remains > >>>untouched. > >> > >>Discarding part of the users requested config like this is not > >>the right thing todo. If the user requests multiple listen addresses > >>and we cannot honour that request that we must report that as an > >>error with code VIR_ERR_CONFIG_UNSUPPORTED > >> > > > >But if we didn't failed parsing that before, domains with such XMLs > >will disappear from the list after daemon restart. > > > > Unless it is before starting the domain and not in PostParse, which is > what you probably meant, sorry for my rapid response ;) Yes, we should be doing this at time of building QEMU cli args. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list