Re: [PATCH 1/1] numatune: Fix parsing of empty nodeset (0, ^0)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/11/2014 12:03 PM, Erik Skultety wrote:
> Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1121837
> ---
>  src/conf/numatune_conf.c                           | 18 +++++++++++--
>  ...emuxml2argv-numatune-memory-invalid-nodeset.xml | 31 ++++++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  1 +
>  3 files changed, 48 insertions(+), 2 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-numatune-memory-invalid-nodeset.xml

We already reject a bitmap with no bits set specified by an empty string.
I think we should be consistent and reject all other representations of an
empty bitmap in virBitmapParse, fixing this for all callers.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]