Re: [PATCH] docs: use unique dev names in <disk> examples

[Martin Kletzander <mkletzan@xxxxxxxxxx>]

On Thu, Aug 07, 2014 at 08:38:11AM -0600, Eric Blake wrote:
> Jiri Moskovcak reported on IRC that the documentation on valid
> <disk> was confusing because it didn't have unique dev='...'
> entries.
>
> * docs/formatdomain.html.in: Use unique names.
>
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
> docs/formatdomain.html.in |   26 +++++++++++++-------------
> 1 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 8950959..08f31c4 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
[...]
> @@ -1601,12 +1601,12 @@
>       &lt;source dev='/dev/sda'/&gt;
>       &lt;geometry cyls='16383' heads='16' secs='63' trans='lba'/&gt;
>       &lt;blockio logical_block_size='512' physical_block_size='4096'/&gt;
> -      &lt;target dev='hda' bus='ide'/&gt;
> +      &lt;target dev='sdb' bus='ide'/&gt;

This one should start with "hd", it's IDE.  Or the bus should be
changed.

>     &lt;/disk&gt;
>     &lt;disk type='volume' device='disk'&gt;
>       &lt;driver name='qemu' type='raw'/&gt;
>       &lt;source pool='blk-pool0' volume='blk-pool0-vol0'/&gt;
> -      &lt;target dev='hda' bus='ide'/&gt;
> +      &lt;target dev='sdc' bus='ide'/&gt;

The same applies here.

>     &lt;/disk&gt;
>     &lt;disk type='network' device='disk'&gt;
>       &lt;driver name='qemu' type='raw'/&gt;
> @@ -1626,7 +1626,7 @@
>       &lt;auth username='myuser'&gt;
>         &lt;secret type='iscsi' usage='libvirtiscsi'/&gt;
>       &lt;/auth&gt;
> -      &lt;target dev='sda' bus='scsi'/&gt;
> +      &lt;target dev='vdb' bus='scsi'/&gt;

This one should start with "sd", it's SCSI.

Rest looks fine, ACK if you match the dev/bus in those three mentioned
places.

Martin

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list