On Wednesday 06 August 2014 05:28 PM, John Ferlan wrote: > > On 08/06/2014 06:20 AM, Prerna Saxena wrote: >> In a system with Fiber Channel Host Adapters, a query to list all Fibre Channel >> HBAs OR Vports currently returns empty list: >> $ virsh nodedev-list --cap fc_host >> >> $ >> >> Libvirt correctly discovers properties for all HBAs. However, the reporting >> fails because of incorrect flag comparison while filtering these types. >> >> This is fixed by removing references to 'VIR_CONNECT_LIST_NODE_DEVICES_CAP_*' >> for comparison and replacing those with 'VIR_NODE_DEV_CAP_*' >> >> Signed-off-by: Prerna Saxena <prerna@xxxxxxxxxxxxxxxxxx> >> --- >> src/conf/node_device_conf.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> > ACK > > Congratulations on your first libvirt patch > > I will push shortly and added "Introduced by original commit id > '652a2ec6'" to the patch commit text. > > John Thanks for pushing it. It has been my first patch to the list after a while :) -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list