On 08/04/2014 02:57 PM, Michal Privoznik wrote: > Currently, the function follows the usual pattern used in our code: > > int ret = -1; > ... > ret = 0; > cleanup: > return ret; > > However, the function always call exit() on error, so the cleanup > label is never jumped onto. Therefore, it doesn't make any sense to > have the parse_argv function return an integer value, if it > effectively can return only value of zero. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > examples/domtop/domtop.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > ACK Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list