On 07/30/2014 02:53 AM, Peter Krempa wrote: > On 07/30/14 06:05, Eric Blake wrote: >> With this in place, I can (finally!) now do: >> >> virsh blockcommit $dom vda --shallow --verbose --pivot >> >> and watch qemu shorten the backing chain by one, followed by >> libvirt automatically updating the dumpxml output, effectively >> undoing the work of virsh snapshot-commit --no-metadata --disk-only. >> Commit is SOOOO much faster than blockpull, when I'm still fairly >> close in time to when the temporary qcow2 wrapper file was created >> via a snapshot operation! >> >> * src/qemu/qemu_driver.c (qemuDomainBlockCommit): Implement live >> commit. >> >> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> >> --- >> src/qemu/qemu_driver.c | 46 +++++++++++++++++++++++++++++++++++++++++----- >> 1 file changed, 41 insertions(+), 5 deletions(-) >> > > ACK and I don't object to push this before rc2 as we already stretched > the feature freeze rules by pushing the NUMA series. As I don't see an rc2 tag yet, and this patch is fairly localized (enabling a feature for qemu block commit, and shouldn't cause regressions on other code) I've gone ahead and pushed this series. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list