Re: [PATCH 2/2] qemu: sound: Handle all possible sound cards in switch statement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/25/2014 10:59 AM, Peter Krempa wrote:
> Use correct type in the switch and handle all sound card models in it so
> that the compliler tracks additions.

*compiler

> @@ -4712,6 +4706,15 @@ qemuBuildSoundDevStr(virDomainDefPtr def,
>              goto error;
>          }
>          break;
> +    case VIR_DOMAIN_SOUND_MODEL_SB16:
> +        model = "sb16";
> +        break;
> +    case VIR_DOMAIN_SOUND_MODEL_PCSPK: /* pc-speaker is handled separately */

Did you mean to report an error for PC speaker too?

> +    case VIR_DOMAIN_SOUND_MODEL_LAST:
> +        virReportError(VIR_ERR_INTERNAL_ERROR,
> +                       _("sound card model '%s' is not supported by qemu"),
> +                       virDomainSoundModelTypeToString(sound->model));

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]