Re: [PATCH] change blkiotune weight range min from 100 to 10

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/24/2014 02:03 PM, Martin Kletzander wrote:
> This reflects the same change made in kernel commit df457f845e (before
> v2.6.38-rc7).  On the rare occasion when the user would try setting
> the weight to value in range <10, 100) on older kernel, we will error
> out with EINVAL properly.  Modifying the error message (adding a hint
> for example) would cause weird logs, especially without stacked error
> messages (I couldn't resist mentioning it again).
> 
> There is no (easy) way of getting the limits from kernel, since it's
> not exposed.

I think removing the limit checks from libvirt, as was done for ranges
specified via XML, would be a nicer fix:

https://www.redhat.com/archives/libvir-list/2013-October/msg00525.html

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]