On 14.7.2014 13:20, Wang Rui wrote: > From: Zeng Junliang <zengjunliang@xxxxxxxxxx> > > This patch introduces vgamem attribute for video model, and sets > its default value as qemu used. Parse it in two ways accroding to > qemu startup parameters supported: -device or -vga. > > Signed-off-by: Zeng Junliang <zengjunliang@xxxxxxxxxx> > Signed-off-by: Wang Rui <moon.wangrui@xxxxxxxxxx> > --- > src/conf/domain_conf.c | 48 ++++++++++++++++++++++++++++++- > src/conf/domain_conf.h | 3 +- > src/libvirt_private.syms | 1 + > src/qemu/qemu_command.c | 75 ++++++++++++++++++++++++++++++++---------------- > 4 files changed, 101 insertions(+), 26 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index 63d97ec..d5a65c3 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/domain_conf.c [..] > index e59ea4c..18d5c17 100644 > --- a/src/libvirt_private.syms > +++ b/src/libvirt_private.syms > @@ -434,6 +434,7 @@ virDomainVcpuPinDel; > virDomainVcpuPinFindByVcpu; > virDomainVcpuPinIsDuplicate; > virDomainVideoDefaultRAM; > +virDomainVideoDefaultVgamem; > virDomainVideoDefaultType; > virDomainVideoDefFree; > virDomainVideoTypeFromString; Move the virDomainVideoDefaultVgamem after virDomainVideoDefaultType and next time, please build the libvirt before posting patches. Another thing, if you want to use some qemu device option, you should introduce new qemu capability and check if the option is available, so there should be three new capabilities for vga.vgamem_mb, vmvga.vgamem_mb and qxl.vgamem_mb. Pavel -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list