On Mon, Nov 24, 2008 at 03:54:30PM +0100, Jim Meyering wrote: > The s/1/-1/ fix induces no semantic change, since the sole use > of virStateActive tests solely for nonzero. > > >From 4bc9713207a2ed6b101e2067f7bba82d1df45987 Mon Sep 17 00:00:00 2001 > From: Jim Meyering <meyering@xxxxxxxxxx> > Date: Mon, 24 Nov 2008 15:52:55 +0100 > Subject: [PATCH] libvirt.c: fix virStateActive return value; document some new functions > > * src/libvirt.c (virStateActive): Return -1 upon error, not 1, > to be consistent with the other virState* functions. > (virStateActive, virStateCleanup, virStateReload, virStateActive): > Add per-function comments. Looks fine to me ! +1 Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list