Re: [libvirt] [PATCH] tests: virsh-all: new script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:
> On Fri, Nov 21, 2008 at 11:16:18AM +0100, Jim Meyering wrote:
>> Actually, this was the first step.
>> This tiny script merely invokes all commands blindly,
>> solely to get test coverage, even if they (as most do) fail.
>
> It at least verifies that the commands don't crash or leak
> memory in the error paths :-)
>
>> +
>> +if test "$VERBOSE" = yes; then
>> +  set -x
>> +  virsh --version
>> +fi
>> +
>> +. $srcdir/test-lib.sh
>
> $srcdir won't be set if you just invoke the test case directly
> as ./virsh-all. Can you add a default value assuming non-VPATH
> build, eg
>
>    test -z "$srcdir" && srcdir=`pwd`

Sure.  Done. and in virsh-synopsis.
I'll commit these tomorrow.

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]